Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trie): removing a blinded leaf should result in an error #11869

Merged
merged 4 commits into from
Oct 22, 2024
Merged

fix(trie): removing a blinded leaf should result in an error #11869

merged 4 commits into from
Oct 22, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Oct 18, 2024 •
edited
Loading

reth/crates/trie/sparse/src/trie.rs

Lines 272 to 274 in 21f303f

// If the path wasn't present in `values`, we still need to walk the trie and ensure that
// there is no node at the path. When a leaf node is a blinded `Hash`, it will have an entry
// in `nodes`, but not in the `values`.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-trie Related to Merkle Patricia Trie implementation labels Oct 18, 2024
@shekhirin shekhirin marked this pull request as ready for review October 18, 2024 09:46
rkrasiuk
rkrasiuk approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@rkrasiuk rkrasiuk added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 21, 2024
@shekhirin shekhirin added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit b3015c7 Oct 22, 2024
39 checks passed
@shekhirin shekhirin deleted the alexey/remove-leaf-blinded branch October 22, 2024 13:46
This was referenced Oct 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @rkrasiuk